@Stroudy
Posted
Hello again, Incredible work on this! You’re making great strides, and I have a couple of suggestions that might push it even further…
- I would put these into a
<ul> <li>, and the text should be wrapped with a<a>so it is accessible with a keyboard using the tab key, Using an<a>tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a<button>or a<div>not intended for links.
<div class="buttons">
<p class="button">GitHub</p>
<p class="button">Frontend Mentor</p>
<p class="button">LinkedIn</p>
<p class="button">Twitter</p>
<p class="button">Instagram</p>
</div>
-
Instead of using this
<section role="main">You can just use a<main>tag inside the<body>of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content. -
Using
font-display: swapin your@font-facerule improves performance by showing fallback text until the custom font loads, preventing a blank screen (flash of invisible text). The downside is a brief flash when the font switches, but it’s usually better than waiting for text to appear. -
While
pxis useful for precise, fixed sizing, such asborder-width,border-radius,inline-padding, and<img>sizes, it has limitations. Pixels don't scale well with user settings or adapt to different devices, which can negatively impact accessibility and responsiveness. For example, usingpxfor font sizes can make text harder to read on some screens, Check this article why font-size must NEVER be in pixels. In contrast, relative units likeremand adjust based on the user’s preferences and device settings, making your design more flexible and accessible. Usepxwhere exact sizing is needed, but prefer relative units for scalable layouts. If you want a deeper explanation watch this video by Kevin Powell CSS em and rem explained. Another great resource I found useful is this px to rem converter based on the default font-size of 16 pixel.
section h1 {
font-size: 24px; }
I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻
