Social links using HTML and SASS

Community feedback

• 

  ItsZubek•130

  @ItsZubekPosted 23 days ago

  The design looks good, although a little more testing would be nice to get it to look closer to the design, but overall is good.

  As for the coding part, the HTML file looks good, as for the css - I have to point out that using fixed values (px) for images might not be the best idea because of the responsive aspect of the component. If you'd just set the width, the height would adjust automatically. And using rem would make the design more versatile.

  Same goes for fonts, using px might not be the best idea - use rem instead.

  When it comes to the list part of the code the only thing I would point out is again, setting the width property to a fixed value. What would happen if you made the text within that list longer? Try setting the width to 100% and instead of using height use padding to make it the right size. If you were to change the font-size property the height would remain the same and you'd need to adjust it manually. Using padding makes the button scale automatically to the font-size property.

  Marked as helpful

  0
• 

  P

  Aurore•50

  @AuroreLPPosted 23 days ago

  I was going to talk about the size of the card and some other details, but then I realised you didn't have access to the figma file, so congratulations to you.

  Another advantage of the Figma files is that you can download the cursor SVG to have exactly the same in the prototype.

  Your code looks good and efficient. With all the data, your solution would have been perfect!

  0