Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social links solution

KTDKasp 20

@KTDKasp

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Hassan Moataz 1,860

@hassanmoaa

Posted

Hello @KTDKasp !

Great Job solving the challenge mate *congrats * 🎉

Some suggestions for improvement.

For the font-size it's is better to use rems and ems but px for this project is no big deal.

font-size : 18px

  • i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:
  • Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.

Which properties are affected?

All of these properties must never ever be declared in pixels:

  • font-size
  • line-height
  • letter-spacing

If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!

  • You should use ems, and rems for font-sizes would be better

This article may help:

https://fedmentor.dev/posts/font-size-px/

Other than that you're good, keep up the good work!

Marked as helpful

0

@emjayruka

Posted

Dear KTDKasp,

I have reviewed your solution and find it commendable, even excellent.

In the event that you do not possess the Figma design files, I would like to suggest utilizing a browser extension named Perfect Pixel.

This extension enables you to conduct precise comparisons between your completed project and the design images provided upon downloading the project, facilitating accurate dimension verification. Its functionality can prove invaluable in your future projects.

Hope you found this helpful

Keep up the excellent work!

1

KTDKasp 20

@KTDKasp

Posted

@emjayruka Thanks a lot! Really cool extension :^)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord