Social-links

Community feedback

• 

  Lokesh•120

  @Lokesh8055Posted 2 days ago

  Got some feedbacks for this solution:

  1. Make sure that your are asking for proper feedback whenever you submit a solution to frontend mentor so that others can better help you out.

  2. get into the habit of including a full modern css reset at the start of the styles in every project. Andy Bell or Josh Comeau both have good ones you can look up and use.

  3. Look up how and when to write alt text on images. There are some great posts about this in the resources channel on discord. Remember, alt is human-readable content not code. This image is really important, so needs a proper description. It needs to say what the image is (QR code) and where it goes to in this case (to FrontendMentor.io).

  4. when building single components like this you still need to consider the context of where that component would be used in a real site. This card would never be used to serve the main heading on a page, so you know it shouldn't have a h1. Use a lower importance heading level like h2 instead.

  5. id tag should be used only once per website. if you want to select multiple elements try to use class based selector and give a proper naming convention. you can read this article(https://www.frontendmentor.io/articles/understanding-css-naming-conventions-bem-oocss-smacss-and-suit-css-V6ZZUYs1xz)

  6. make sure the component can't hit screen edges by giving a wrapping element a little padding on all sides (eg body or main in this)

  7. please updated your Readme.md file properly explaining what you have done. you can go through ReadmeTemplate.md file for better understanding

  8. Add screenshots in your code for different screens.

  9. use rem units for font sizes, width also.

  Marked as helpful

  0