Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
not much
What challenges did you encounter, and how did you overcome them?not much
What specific areas of your project would you like help with?not much
Community feedback
- P@emil-raubachPosted 2 months ago
Hello @SerhiiDer,
I looked at your solution to the challenge and wanted to provide some suggestions. Keep in mind I'm a newbie as well so take it with a grain of salt!
Use semantic HTML
- The name seem more like a heading - suggest using a
<h1>rather than the<p>for the name.
Links and Active State
- You have the hover working to change the background color, but the text stays the same color. I used the same structure as you at first, with a list and list items nested with the
<a>element but couldn't get the hover to work correctly. So I ended up simplifying the HTML with just a div that wrapped the anchor tags (noulorli).
But, overall it looks really good - nice job on this exercise!
0 - The name seem more like a heading - suggest using a
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord