Design comparison
SolutionDesign
Community feedback
- @StroudyPosted 2 months ago
Hey you should be proud of this solution! Some things I noticed,
- Missing a
<meta>
description tag for SEO purposes, - Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
- You should add a
font-display: swap;
property to your@font-face
, Leverage the font-display CSS feature to ensure that text is user-visible while web fonts are loading, Increasing performance. - You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
- Using
max-width: 100%
ormin-width: 100%
is way more responsive then justwidth:100%
, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail. - You should avoid using
px
as it is an absolute unit and not a responsive unit likerem
orem
, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
I hope you found some of this information helpful and I look forward to seeing some more from you, Happy coding!
Marked as helpful1 - Missing a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord