Social links profile with Scss

Community feedback

• 

  Alex•3,130

  @Alex-Archer-IPosted 4 months ago

  Hi!

  It's quite a neat work, congrats =)

  I can give a couple of suggestions about how you can improve it.

  You already use flex for centering your card, so it's not necessary to center it with margins. You can see it in the dev console - if you remove margins nothing change.

  Than you should use ul or ol tags when you deal with every kind of lists. Here is the list of links, so they should be a tags. So, this part should looks like that:

  <ul>
      <li><a href="#">It's a link here!</a></li>
      ...and more links here
  </ul>
  

  And you use flex with links too, so you can use gap property to create equal gaps between them - it'll be more convenient than margins =)

  Hope that helps. Good luck =)

  Marked as helpful

  1