@EugeniaAntonova
Posted
Hi and congradulations on this challenge! I really love the color pallet you`ve chose. A tiny bit of advice:
-
in rectangular shapes with not equal sides, like you have here, it is better to use border-radius given in px, em, rem etc. The result you have got now does not seem planned
-
use transitions for almost anything that changes, especially as significantly as background color in your links. It makes the feel of you UI more natural and frieandly to the eye
-
for margins it is a better choice to use margin property. When creating a document flow it is better to make margins from top to bottom and from left to right. In this way you would have h1 margin--bottom: .5em (for instance), .location margin-bottom: 1em (or just twice as the previous one to create connection between name and location and separate slogan as a thing of its own)
Good luck!
Marked as helpful
@CatalinaF-S
Posted
Thank you @EugeniaAntonova for your useful feedback. I will review my code again and put in practice your advices :)
@EugeniaAntonova
Posted
@CatalinaF-S happy to help! All the best to you and your career!
