Design comparison
Solution retrospective
I've tried code generation plugin from figma, it made me slightly faster but I had to correct a lots of classes to repair responsiveness and remove clutter.
What challenges did you encounter, and how did you overcome them?Typesetting children in SocialLink component was a bit trouble and I had to look it up. Still not sure if it couldn't be typed better.
What specific areas of your project would you like help with?CSS review, maybe the types in SocialLink component
Community feedback
- @danielmrz-devPosted 6 months ago
Hello there!
Congrats on completing the challenge! ā
Your solution looks great!
š It's recommended to use semantic HTML elements like
<ul>
and<li>
for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.Here's and example on how you can refactor your code:
After Refactoring
<ul class="list-container"> <li><a href="#">Github</a></li> <li><a href="#">Frontend Mentor</a></li> <li><a href="#">LinkedIn</a></li> ... </ul>
By using
<ul>
and<li>
, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.I hope you find this helpful!
Keep up the excellent work!
Marked as helpful1@raswondersPosted 5 months ago@danielmrz-dev thank you for your time to review. Using a list is a great suggestion. I'll make sure to use it.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord