Social Links profile with Hover & Glow Animation through Keyframes
Design comparison
Solution retrospective
I would like advice for writing beter semantic HTML where possible.
Community feedback
- @Ezekiel225Posted 9 months ago
Hey @ryanzeroseven nice work !
I noticed that you've added your own details in this design that's good, but here is a thing, please try to match the font, font size, box sizing and most important responsive layout as per the design provided in the template.
I hope you will take this feedback in a positive manner.
Happy coding.
0@ryanzerosevenPosted 9 months agoHi, Thank you for the feedback. One of the π‘ Ideas to test yourself was to: Personalize the project to add your own information, links, and color palette (if you want to test your creativity!) According to your feedback I did too much. Can you please tell me where, at which line I did not respect the challenge regarding font-size, font and box-sizing? I am not a paid user so I only have my eyes to get as close as possible to the design.
I hope you can provide me with more insights as to what you were referring about. @Ezekiel225
1@danielmrz-devPosted 9 months agoHello @ryanzeroseven !
Despite Ezekiel's comment, I have another perspective:
I think it's nice what you did on the project. I do the same on my projects whenever there's room for a little customization.
The templates given by the platform are not supposed to be done 100% exactly like the design if you don't want to. Of course it's a good idea trying to macth the original design, but you are free to customize it π
1@ryanzerosevenPosted 9 months agoThank you, I appreciate your feedback. Hope you will keep doing so in the future. π @danielmrz-dev
1 - @hassanmoaaPosted 9 months ago
Hello @ ryanzeroseven!
i see a minor problem that could mess your project if it's bigger and there are more content in it.
--letter-spacing: 2px;
For the letter spacing it's is better to use rems and ems but px for this project is no big deal.
Never use pixels for Letter-spacing, here's why:
- Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.
Which properties are affected? All of these properties must never ever be declared in pixels:
- font-size
- line-height
- letter-spacing
If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!
- You should use ems, and rems for font-sizes would be better.
This article may help: https://fedmentor.dev/posts/font-size-px/
Other than that you're good, keep up the good work! Good luck mate.
0@ryanzerosevenPosted 9 months agoHi, thank you for your feedback. I agree with you completely when it comes using different units over px. I had no idea that some sites are inaccessible when used px, is this explained in the article? Or do you have an example, I thought pxβs were widely accepted as a unit. As you might have seen itβs only used in my box shadows and letter spacing for this small component. For future I will keep it in mind and I will definitely give the article a read. Thanks
@hassanmoaa
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord