Hey Jordan,
your project looks good!
These would be my suggestions:
-Images should be in the HTML not in the CSS (only background images). This way you could add alt text
-In the CSS, you could add a <generic-name> to the font family. A fallback in case the main font doesn't work.
-all the HTML elements are at the beginning of the row. This makes the code harder to read.
All in all looks very good!
Marked as helpful
@jjdavenport
Posted
@BuraYu thanks for your feedback, can you elaborate further regarding the html elements being at the beginning of the row?
@jjdavenport
Sure. The indentation in the index.html is off. Each nested element should be indented with the parrent.
You can check this article: https://courses.cs.washington.edu/courses/cse154/17au/styleguide/html-css/spacing-indentation-html.html#:~:text=Spacing%20and%20indentation%20should%20be,inside%20of%20its%20parent%20tag.&text=Place%20a%20line%20break%20after%20every%20block%20element.
Marked as helpful
