P
Steven Stroud• 4,140
@Stroudy
Posted
Hey, Great job with this solution you should be proud, A few things I noticed,
- Missing a
<meta>
description tag for SEO purposes, - Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
@media
should also be in relative units likerem
orem
,- Using
max-width: 100%
ormin-width: 100%
is way more responsive then justwidth:100%
, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail. - You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻
Marked as helpful
1
Mohamed11Esam• 40
@Mohamed11Esam
Posted
@Stroudy Thank you so much ❤️🫡
0