Social Links Profile (vanillia CSS)

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 9 months ago

  Hello @Mlchaell!

  Your solution looks great!

  I have a couple of suggestions (about semantic HTML) for improvement:

  📌 First: Use <main> to wrap the main content instead of <div>.

  Think of <div> and <span> in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.

  📌 Second: Only use one <h1> per page - this should represent the main heading/title for the whole page.

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1

  ---

  

  P

  Michael•380

  @MlchaellPosted 9 months ago

  @danielmrz-dev Thank you for the feedback, I'll update my solution!

  Do you think I setup the widths of the main container (.container) and then the button elements (.links, .links__btn) inside of it correctly? I feel like all I did was kind of just throwing something together and hoped it worked

  1

  

  Daniel 🛸•44,310

  @danielmrz-devPosted 9 months ago

  @Mlchaell

  Yeah looks good to me.

  Just try not using fixed width values for the main containers, specially when they need to be responsive and adapt to the screen.

  Instead of using width, you can use max-width. By doing this, your card remains responsive, but only grows until a certain point.

  Marked as helpful

  1

  

  P

  Michael•380

  @MlchaellPosted 9 months ago

  @danielmrz-dev Alright, thank you!

  1