
Design comparison
SolutionDesign
Please log in to post a comment
Log in with GitHubCommunity feedback
- @imbraian
Hello Ayoub! I've been looking at your project, and in terms of design, it looks excellent to me. Nonetheless, I'd like to give you the following advice:
- You should use more descriptive classes; for this, I recommend using the BEM methodology. That will help you a lot in the readability of your code. Always program with the mindset that other programmers will see it. If you're not familiar with BEM yet, I'll share a video with you to help you understand what I'm talking about: https://www.youtube.com/watch?v=xaXmoVZ3koo
- Congratulations on using custom properties (Variables).
- Instead of using flex in "section-2," you should use it on the parent element of the <a> tags; in this case, the <li> tag is the parent, so you should use flex there. And you should remove display block.
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord