Social links profile

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 6 months ago

  Hello there!

  Congrats on completing the challenge! ✅

  Your solution looks great!

  📌 It's recommended to use semantic HTML elements like <ul> and <li> for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.

  Here's and example on how you can refactor your code:

  After Refactoring

  <ul class="list-container">
      <li><a href="#">Github</a></li>
      <li><a href="#">Frontend Mentor</a></li>
      <li><a href="#">LinkedIn</a></li>
      ...
  </ul>
  

  By using <ul> and <li>, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.

  I hope you find this helpful!

  Keep up the excellent work!

  Marked as helpful

  2

  ---

  

  P

  andiaz•150

  @andiazPosted 6 months ago

  @danielmrz-dev Hi Daniel! Wow, thanks a lot for your thoughtful comment :) I have now changed the implementation to use <ul> and <li> instead of <div> and <button>. I honestly had no idea it made more sense to represent this as a list so thanks for clarifying :)

  Btw, your score here on Frontend Mentor is incredible! Awesome Github profile too! Keep it up :)

  1
• 

  Lê Hoàng Long•290

  @JamesWallison1Posted 6 months ago

  Really impressive! This solution is really really amazing I have to admit. Just wanna ask if you did miss the media queries or not? Media queries is really important, maybe your code right now is no need for media queries but further challenges will require media queries, such like "create three dots in phone query,..." So if you didn't remember to add it, make sure to take it into account! And you're good to go! Thanks a lot for reading this small comment

  Also you are the second person to have this container "perfect pixel". Everything is alike about 98% of the design. So keep pushing and pushing to be more successful. Again, congratulation!

  Marked as helpful

  1

  ---

  

  P

  andiaz•150

  @andiazPosted 6 months ago

  @JamesWallison1 Thanks a lot! Really helpful comment too :) For some reason I completely missed the responsive design part. So now I added some basic media queries to the design so that it works on mobile screens as well. E.g. changed the padding and margins to slightly smaller on mobile (based on the design).

  I appreciate the kind comments about the implementation being almost pixel perfect, means a lot! :)

  1

  

  Lê Hoàng Long•290

  @JamesWallison1Posted 6 months ago

  @andiaz That's really good! Seeing that you are improving and taking my advice, I am really happy :) Remember to push yourself more out of the comfort zone to become a successful and hard core FEM member

  1