@Stroudy
Posted
Amazing job with this! You’re making fantastic progress. Here are some small tweaks that might take your solution to the next level…
- I would put these into a
<ul> <li>
, and the text should be wrapped with a<a>
so it is accessible with a keyboard using the tab key, Using an<a>
tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a<button>
or a<div>
not intended for links.
<div class="buttons">
<a href="#"><button type="button"> GitHub</button></a>
<a href="#"><button type="button"> Frontend Mentor </button></a>
<a href="#"><button type="button"> LinkedIn </button></a>
<a href="#"><button type="button"> Twitter </button></a>
<a href="#"><button type="button"> Instagram </button></a>
</div>
-
Developers should avoid using pixels (
px
) because they are a fixed size and don't scale well on different devices. Instead, userem
orem
, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter. -
For future project, You could downloading and host your own fonts using
@font-face
improves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. -
Using
rem
orem
units in@media
queries is better thanpx
because they are relative units that adapt to user settings, like their preferred font size. This makes your design more responsive and accessible, ensuring it looks good on different devices and respects user preferences.
Great job taking the time to learn! Your efforts are paying off, and I hope these insights guide you to even more success. Keep pushing forward, and remember, you’ve got this! Enjoy your coding adventures! 💪
Marked as helpful
@muiruri3000
Posted
Thanks a lot@Stroudy for your encouragement. Will sure take in those corrections.
Am also having trouble making images visible on live site, am forced to use the absolute references. How do I go about this?
@Stroudy
Posted
@muiruri3000, Hey, No problem, try to add the image in HTML with the <img>
tag like this <img src="./" alt="">
, If you put the ./
in the src
you can go to images and select the image.
There are many benefits to loading it in HTML over CSS.
After you have done that you can style it with this code snippet,
width: 100%;
height: auto;
max-width: 5.5rem;
border-radius: 50%;
Hope this was helpful, I would like to know if this was successful, Good luck!