Design comparison
Solution retrospective
I can complete the project more quickly than last time.
What challenges did you encounter, and how did you overcome them?No
What specific areas of your project would you like help with?No need help
Community feedback
- @DylandeBruijnPosted 4 months ago
@Gulizuli
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution 🎉
- Use of semantic HTML elements
- Clear descriptive CSS classes
Things you could improve ✍️
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
Try putting your links in a list.
-
Try making your card responsive.
-
You don't have to wrap your image in a
div
, you can achieve the same result by styling the image directly.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful1@GulizuliPosted 4 months ago@DylandeBruijn
Hi ! Dylan de Bruijn Thanks for your suggestions !! I learn a lot from them.🎉
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord