
Design comparison
Solution retrospective
I'm proud of how much it looks exactly like the figma design. I'm proud of the component structure.
What challenges did you encounter, and how did you overcome them?I found trying to use paths for images in json quite difficult to implement. I still haven't figured it out. I created a json file to extract profile data so that way I can scale it up in the future. Since I wasn't able to correctly extract a file path to the image in the json file, I imported it in the component that needed it.
What specific areas of your project would you like help with?I would like help on how to properly put a file path in json file to properly extract the heroImg and dynamically render it, into a react component.
Community feedback
- @EdelmiroAntonPosted 3 months ago
Hey Michael! Congrats to finish this challenge! I really like your project structure applying the benefits of React :D
One thing I'd like to comment is that you should put in practice and take into account the ARIA Landmarks. Including semantic HTML or ARIA Roles will let you organize and structure your web page.
On the web sites, we should have at least one
<main>
some heading tag (<h1>, <h2>
), etc or a<section>
, for example. This way we'll contribuite with the accesibility and for whom use the screen readers.If you havent'd done so yet, I recommend you this site: ARIA Landmarks.
Also I have installed the Chrome extension Landmark Navigation via Keyboard or Pop-up to analize how the sites are structured.
I hope this feedback finds you useful.
Happy coding and go on!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord