@DylandeBruijn
Posted
@vvvasavii
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution 🎉
- Responsive
- Use of semantic HTML elements
- Clear descriptive CSS classes
Things you could improve ✍️
-
Add a bit of padding to your body element so the card has room to breath on smaller viewports.
-
Try adding links (
<a>
) inside your list items so the buttons can link to the websites.
Example:
<a href="https://www.example.com">Visit Example.com</a>
By adding the href
attribute you get the cursor pointer when hovering over the link as well, which is a nice addition!
-
You don't have to put the image in a wrapper
<div>
, you can achieve the same styling by styling the image directly. -
Try using
<p>
tags for pieces of text like the location and about. -
Try experimenting more with Flexbox.
-
Look into CSS variables to make your code more reusable.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful
@vvvasavii
Posted
Thanks,ill keep that in mind@DylandeBruijn