Design comparison
Solution retrospective
im mostly proud of how i was able to make this project rather easily,so im proud of my personal improvement.
What challenges did you encounter, and how did you overcome them?i had some problems with the accounts tree part.but then i gave it a thought and used ul which saved so much of my time and made the project a whole lot easier.
What specific areas of your project would you like help with?pls review my code if you happen to have some spare time and point out any mistakes or useless pieces of codes. I really look forward to feedbacks,negative and positive both :)
Community feedback
- @DylandeBruijnPosted 5 months ago
@vvvasavii
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution 🎉
- Responsive
- Use of semantic HTML elements
- Clear descriptive CSS classes
Things you could improve ✍️
-
Add a bit of padding to your body element so the card has room to breath on smaller viewports.
-
Try adding links (
<a>
) inside your list items so the buttons can link to the websites.
Example:
<a href="https://www.example.com">Visit Example.com</a>
By adding the
href
attribute you get the cursor pointer when hovering over the link as well, which is a nice addition!-
You don't have to put the image in a wrapper
<div>
, you can achieve the same styling by styling the image directly. -
Try using
<p>
tags for pieces of text like the location and about. -
Try experimenting more with Flexbox.
-
Look into CSS variables to make your code more reusable.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord