Design comparison
Solution retrospective
If you could review my code and give me feedback on what I could fix and improve, I would really appreciate it.
Community feedback
- @DylandeBruijnPosted 5 months ago
Hiya @gabriel-m-dev,
Congratulations on your solution, it looks very close to the design. Good to hear you were able to align the elements correctly, Flexbox is a very helpful layout tool and I can recommend taking the time to learn it. Maybe you could try to center your card in the middle of the page using Flexbox as a start? I like your use of CSS variables and semantic elements!
A small oversight:
- The hover animations are missing on the buttons, it might be fun to try to add them to really make your solution pop!
I hope you find my feedback helpful, and I would appreciate it greatly if you could mark my comment as helpful if it was!
Let me know if you have more questions and I'll do my best to answer them.
Marked as helpful1@gabriel-m-devPosted 5 months agoThank you for the response, I'm trying to center the pages at the beginning but it's something I'm struggling with. I'll keep trying! I'm glad you liked it, I'll definitely keep practicing Flexbox.@DylandeBruijn
1 - @danielmrz-devPosted 5 months ago
Hello there!
Congrats on completing the challenge! ā
Your solution is really impressive!
I've got a couple of ideas (about how to use HTML better) that could make it even stronger:
š First: Think about using
<main>
to wrap your main content instead of<div>
.Imagine
<div>
and<span>
in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.š Second: Don't skip heading levels ā start with
<h1>
, then use<h2>
, and so on.It's more than just text size ā it's about structuring your content effectively:
- The
<h1>
to<h6>
tags are used to define HTML headings. <h1>
is for the most important heading.<h6>
is for the least important heading.- Stick to just one
<h1>
per page ā it should be the main title for the whole page.
These tweaks might not change how your page looks, but they'll make your HTML code clearer and help with SEO and accessibility.
Hope that's helpful!
Keep up the great work!
Marked as helpful0@gabriel-m-devPosted 5 months agoThank you! I will definitely try to improve the semantics and the elements for the next challenge :) @danielmrz-dev
0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord