Design comparison
Solution retrospective
Kept learning to make the solution as close as the challenge
What challenges did you encounter, and how did you overcome them?No challenges
What specific areas of your project would you like help with?Nothing, but if someone has any notes on how to improve my solution i would like to know that very much
Community feedback
- @Raptor0x1Posted 5 months ago
-
Your attribution class has been commented out.
-
There is no need to use flexbox everywhere. Usage in class main and profile was not needed.
-
You should use anchor tags instead of button tag. Button is used when the user has to do some activity on the same page but on this links profile when user will click on the button, he would have to go to another website. So Button is not appropriate here, Instead make use of anchor tags and maybe wrap them in the list tag of unordered list tag.
-
Lastly, Use em or rem instead of px for things like font-size , margin, padding, border-radius etc.
Marked as helpful0@MaxCoder-mcPosted 5 months agoThanks for your helpful comment.
- If flexbox was not needed in main and profile class, what faster way do you suggest to center the items in it? @Raptor0x1
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord