Design comparison
Solution retrospective
I am proud of the progress I am making in my CSS skills, thanks to frontend mentor. I used a CSS reset and a CSS lint as the guy from Discord advised me last time and they turned out to be really helpful. I will start using them more in my upcoming projects.
What challenges did you encounter, and how did you overcome them?I made some stupid mistakes which got me stuck for a while but I reviewed my code several times and discovered them.
What specific areas of your project would you like help with?Nothing specific this time, just any general feedback would be helpful!
Community feedback
- @DylandeBruijnPosted 4 months ago
Hiya @razanabbas,
Congratulations on a good looking solution to this project! Happy to hear that you were able to make good use of a CSS reset and CSS lint. Everyone makes mistakes when working on a project, and Bob Ross would say they are happy little accidents. Being critical of your own work is a good skill to have! You made good use of semantic HTML elements and clear descriptive classes, props!
A bit of friendly constructive feedback:
-
You could try adding a bit of
padding
to yourbody
tag so the card has a bit of space between itself and the viewport. -
If you want have a look at CSS variables / custom properties, they help out a great deal when you use the same value (colors for example) in your codebase, while giving them a descriptive name at the same time.
-
You could replace the
h3
elements in your list bya
tags because they are supposed to be linking to the relevant websites. Good job on the styling!
Everything else looks great! I would appreciate it if you could mark my feedback as helpful when you have the chance and if it helped you out.
Happy coding!
Marked as helpful0 -
- @DanielfwwPosted 4 months ago
Hey razanabbas - great job on finishing this project! If I would recommend anything - it would be adding a href into your divs and doing hovers, that way your text would change when clicked on. Everything can be done in html so you dont have to chance your css file. Good luck and great job!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord