Social Links Profile using HTML and CSS

Community feedback

• 

  Lê Hoàng Long•290

  @JamesWallison1Posted 6 months ago

  You're doing great! Congratulation of completing one of the FEM challenges, really impressive I have to admit! It is great from the first look but there are some mistakes we need to discuss about.

  • First, it is considered that you use landmarks instead of div. Landmarks are such like: <main></main> <section></section> <footer></footer>,... using div is not wrong but it can not describe what is the role of each individual part? So consider changing those div to main based on what the role of that part is.
  • Second, I am seeing that your card is not being centered properly, well there is a tip for you is that using: margin: 0 auto This will automaitcally center your whatever div, so consider adding that to your css

  And you are good to go! Your solution is really great I have to admit! So keep practicing and practicing for perfection! Thanks a lot for spending time reading my small comment

  Marked as helpful

  0

  ---

  

  osenprema•170

  @osenpremaPosted 6 months ago

  @JamesWallison1

  Thanks for your time and advice. I'll keep them in mind ;).

  1