Frontend Mentor | Social links profile using Flexbox, BEM, Variable & Logical Properties coding challenge solution

Community feedback

@Code-Beaker

Posted 2 months ago

Hi there! You've done a great job with this project 🎉

I have taken a look at your live site solution and the source code. You've done a great job with your CSS by using the custom properties.

One suggestion I want to forward is to split your CSS into multiple files to keep it cleaner. For example, store the custom properties and variables inside a variables.css file and put the resets inside a resets.css file.
Instead of px use a relative unit like rem or em. Here's an article that explains you about it.

Hope this helps you 😄

Marked as helpful

@dedo-dev

Posted 2 months ago

@Code-Beaker thanks a million, really appreciate it. By the next project I will use multiple files to my CSS.

Just one question, I didn't use relative units just for the border-radius and text-underline-offset, also for this stuff I need to use it?

Thanks again ✌️

@Code-Beaker

Posted 2 months ago

Hi, @dedo-dev. I'm glad you found my comment helpful.

Yes it is fine and better to use relative units for properties like border-radius.

Keep coding 😄

Social links profile using Flexbox, BEM, Variable & Logical Properties