@Stroudy
Posted
Amazing job with this! You’re making fantastic progress. Here are some small tweaks that might take your solution to the next level…
-
Using a
<main>
tag inside the<body>
of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content. -
Your heading elements
<h1><h6>
Missing 2 3 4 5, Heading elements should be in sequentially-descending order (e.g.,<h1>
,<h2>
,<h3>
) to create a clear content structure, improving accessibility and SEO. Skipping levels or using them out of order can confuse screen readers, affect search engine rankings, and make your content harder to understand. -
I would put these into a
<ul> <li>
, and the text should be wrapped with a<a>
so it is accessible with a keyboard using the tab key, Using an<a>
tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a<button>
or a<div>
not intended for links.
<div class="link">
<a class="mint" href="https://github.com/rawatdinesh10">GitHub</a>
<a class="mint" href="https://www.frontendmentor.io/profile/rawatdinesh10">Frontend Mentor</a>
<a class="mint" href="https://linkedin.com/in/rawatdinesh33">LinkedIn</a>
<a class="mint" href="https://x.com/dineshrawat325"> Twitter</a>
<a class="mint" href="https://www.instagram.com/rawatdinesh333">Instagram</a>
</div>
-
Using
max-width: 100%
ormin-width: 100%
is more responsive than justwidth: 100%
because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning. -
Developers should avoid using pixels (
px
) because they are a fixed size and don't scale well on different devices. Instead, userem
orem
, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter. -
For future project, You could downloading and host your own fonts using
@font-face
improves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable.
You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟
Marked as helpful
@rawatdinesh10
Posted
@Stroudy Thank you so much for such a great explanation and solution of the challenge. I'm going to follow each step mentioned above. Thanks a lot.
@rawatdinesh10
Posted
@Stroudy Please help me in sizing the img. How should I size my img in the challenge to design file img?