Design comparison
Solution retrospective
I am most proud of avoiding any media queries and emphasizing type safety within my Astro components. The Card.astro component makes changes to the name, location, bio, and profile image easy without digging into the code. Similarly, the Links.astro component iterates over a list of string-based link/label pairs, allowing additional links to be added or removed with ease.
What challenges did you encounter, and how did you overcome them?I am still getting comfortable with TypeScript so I have to regularly look at reference material and my old projects. At this point TS is primarily for type safety as I read JSON data to map to HTML elements in my components.
What specific areas of your project would you like help with?Nothing in particular but I welcome feedback.
Community feedback
- @danielmrz-devPosted 6 months ago
Hello there!
Congrats on completing the challenge! ā
Your solution looks great!
š It's recommended to use semantic HTML elements like
<ul>
and<li>
for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.Here's and example on how you can refactor your code:
After Refactoring
<ul class="list-container"> <li><a href="#">Github</a></li> <li><a href="#">Frontend Mentor</a></li> <li><a href="#">LinkedIn</a></li> ... </ul>
By using
<ul>
and<li>
, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.I hope you find this helpful!
Keep up the excellent work!
Marked as helpful0@crossinguardPosted 6 months ago@danielmrz-dev Awesome, thanks! I just went back and updated my
Links.astro
component based on your feedback.0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord