Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social links profile

LAZUR 30

@Lazur05

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P
Steven Stroud 4,160

@Stroudy

Posted

Hello again, Massive improvements, Fantastic effort on this! You’re really nailing it. Just a few things I noticed that could make it even better…

  • I think it would be best to put these in a <ul>, <li> because it is a list of social links,
      <div class="links">
        <a href="#">GitHub</a>
        <a href="#">Frontend Mentor</a>
        <a href="#">LinkedIn</a>
        <a href="#">Twitter</a>
        <a href="#">Instagram</a>
      </div>
  • I think you can benefit from using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,

  • On your main .card I would also change the width: 370px; to rem.

You smashed this challenge, I hope you found this advice helpful! Keep up the great work, and don’t forget to dive deeper into the details. You’re doing amazing, and I can’t wait to see what you create next. Happy coding! 🚀

Marked as helpful

0

LAZUR 30

@Lazur05

Posted

@Stroudy Hi, thanks for your help :). I have made some changes as you suggested, does it look okay, or I should make some more changes?

1
P
Steven Stroud 4,160

@Stroudy

Posted

@Lazur05, Perfect ✅

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord