Social links profile

Community feedback

• 

  P

  Steven Stroud•11,910

  @StroudyPosted 2 months ago

  Hello again, Massive improvements, Fantastic effort on this! You’re really nailing it. Just a few things I noticed that could make it even better…

  • I think it would be best to put these in a <ul>, <li> because it is a list of social links,

        <div class="links">
          <a href="#">GitHub</a>
          <a href="#">Frontend Mentor</a>
          <a href="#">LinkedIn</a>
          <a href="#">Twitter</a>
          <a href="#">Instagram</a>
        </div>
  

  • I think you can benefit from using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,

  • On your main .card I would also change the width: 370px; to rem.

  You smashed this challenge, I hope you found this advice helpful! Keep up the great work, and don’t forget to dive deeper into the details. You’re doing amazing, and I can’t wait to see what you create next. Happy coding! 🚀

  Marked as helpful

  0

  ---

  

  LAZUR•80

  @Lazur05Posted 2 months ago

  @Stroudy Hi, thanks for your help :). I have made some changes as you suggested, does it look okay, or I should make some more changes?

  1

  

  P

  Steven Stroud•11,910

  @StroudyPosted 2 months ago

  @Lazur05, Perfect ✅

  1