
Design comparison
Community feedback
- @Tev-The-DevPosted 3 months ago
Looking at your style sheet, it is very well detailed and organized. I may not understand the top section to reset the styles, but it is laid out in such a way that it is easy to follow. I did notice that there are some sections where you repeat the same code, i.e. the display:flex; areas. This could all be condensed in one section where you include all the tags that use that code to reduce retyping the same snippets for each section. Other than that, it is well done. Even though I took a screenshot of my design to compare to the sample when finished, I still couldn't get the sizing of everything exact. Yours is nearly perfect in size.
Marked as helpful1P@bowman89Posted 3 months ago@Tev-The-Dev Thank you much for the feedback mate! So, what you're saying is to do let's say .class1, .class2, .class3: { display:flex; And so on... }
If not please elaborate🤗
0@Tev-The-DevPosted 3 months ago@bowman89 yes exactly. It will help you clean up the code and make it so that you only need to change that one section to make changes to all of it. If something needs a specific setting outside of that, you can always over-ride it by putting that attribute setting in its own tag. For example, if everything needs to be center aligned, then all of those items will be grouped together, and then if one item needs to be justified or left aligned, you over-ride the center alignment by putting that setting in that specific tag.
Marked as helpful1P@bowman89Posted 3 months ago@Tev-The-Dev Ah I understand! Thank you mate! Really nice of you taking your time to answer with such detail! I will definitely try this on the recipe page I'm on atm. I would love to get feedback from you again 👍🙌
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord