Social links profile templates

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @mohammed-rony

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things you could improve ✍️

  • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

  • I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

  • Try using semantic HTML elements like main, section and article.

  • By convention you should put dashes (-) between words in you CSS classes.

  • You have a syntax error in your font-family, the comma is missing:

  font-family: 'Inter' sans-serif; should be font-family: 'Inter', sans-serif;

  • Be careful with setting a low line-height. On smaller viewports your text overlaps.

  • Try putting your links in a list.

  I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  Marked as helpful

  1
• 

  Mohammed Rony•40

  @mohammed-ronyPosted 4 months ago

  Hello. my mistake , I will try next time hopefully it will be better. Thanks for your feedback. Again your feedback is so many helpful for me ❤

  0