Social Links Profile Solution

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 6 months ago

  Hello there!

  Congrats on completing the challenge! ✅

  Your solution looks great!

  📌 It's recommended to use semantic HTML elements like <ul> and <li> for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.

  Here's and example on how you can refactor your code:

  After Refactoring

  <ul class="list-container">
      <li><a href="#">Github</a></li>
      <li><a href="#">Frontend Mentor</a></li>
      <li><a href="#">LinkedIn</a></li>
      ...
  </ul>
  

  By using <ul> and <li>, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.

  I hope you find this helpful!

  Keep up the excellent work!

  Marked as helpful

  1

  ---

  

  Mostafa•50

  @MostafaSaad1987Posted 6 months ago

  @danielmrz-dev Thank you for your great tips, Daniel! I have changed the button container to be more semantic using your list approach.

  1
• 

  Pedro Silva•140

  @pmcsilva90Posted 6 months ago

  Hi Mostafa.

  Looks pretty good! Your design is a bit narrower but a minor aesthetic detail.

  I liked your inclusion of a transition effect and now I wish I would have included it in my solution.

  Keep up the good work!

  1

  ---

  

  Mostafa•50

  @MostafaSaad1987Posted 6 months ago

  @pmcsilva90 Thank you!

  0