Social links profile solution using HTML and CSS

Community feedback

• 

  P

  Steven Stroud•11,890

  @StroudyPosted about 2 months ago

  Awesome job tackling this challenge! You’re doing amazing, and I wanted to share a couple of suggestions that might help refine your approach…

  • These <div> should really have semantic tags like headings (<h1> to <h6>) and paragraphs (<p>) convey structure and meaning to content, improving accessibility, SEO, and readability by helping search engines and screen readers interpret the content.

          <div class="name">Jessica Randall</div>
          <div class="location">London, United Kingdom</div>
  

  • I would put these into a <ul> <li>, and the text should be wrapped with a <a> so it is accessible with a keyboard using the tab key, Using an <a> tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a <button> or a <div> not intended for links.

        <div class="links">
            <p class="social">Github</p>
            <p class="social">Frontend Mentor</p>
            <p class="social">LinkedIn</p>
            <p class="social">Twitter</p>
            <p class="social">Instagram</p>
        </div>
  

  • Developers should avoid using pixels (px) because they are a fixed size and don't scale well on different devices. Instead, use rem or em, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter.

  • Using max-width: 100% or min-width: 100% is more responsive than just width: 100% because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning.

  You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟

  Marked as helpful

  0

  ---

  

  Rahul K Dinesh•290

  @b16h22Posted about 2 months ago

  Thanks for the valuable feedback. I'll try to include the changes in my future challenges and projects @Stroudy

  1

  

  P

  Steven Stroud•11,890

  @StroudyPosted about 2 months ago

  Hey @b16h22, You got this bro, Thank you for sharing your solution!

  1
• 

  Carmela•80

  @carmela925Posted about 2 months ago

  A little bit smaller but overall very similar

  Marked as helpful

  0

  ---

  

  Rahul K Dinesh•290

  @b16h22Posted about 2 months ago

  Thanks for the feedback@carmela925 . I did fix the sizing later but my free screenshots ran out so I couldn't update the render after the fix.

  0