Social Links Profile Solution

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 6 months ago

  Hello there!

  Congrats on completing the challenge! ✅

  Your solution looks great!

  📌 It's recommended to use semantic HTML elements like <ul> and <li> for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.

  Here's and example on how you can refactor your code:

  After Refactoring

  <ul class="list-container">
      <li><a href="#">Github</a></li>
      <li><a href="#">Frontend Mentor</a></li>
      <li><a href="#">LinkedIn</a></li>
      ...
  </ul>
  

  By using <ul> and <li>, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.

  I hope you find this helpful!

  Keep up the excellent work!

  Marked as helpful

  0

  ---

  

  OlsanX•150

  @olsanxPosted 6 months ago

  Thank you very much, i will do that @danielmrz-dev

  1
• 

  Lê Hoàng Long•290

  @JamesWallison1Posted 6 months ago

  Seems you have made a huge progess! Congratulation on completing the challenges! Really impressive! But just wanna have a question: Just wonder why you style the container to have cursor: pointer? I don't think this is a necessary one, I think we just need to add cursor: pointer to those buttons and those attributions, so you can consider removing them! That's all! Thanks a lot for spending time reading my comment!

  Marked as helpful

  0

  ---

  

  OlsanX•150

  @olsanxPosted 6 months ago

  Thank you, I will do that, you're right@JamesWallison1

  1