Design comparison
Solution retrospective
I'm proud to have managed to come up with such a similar replica with so little experience!
What challenges did you encounter, and how did you overcome them?My biggest challenge was knowing how to identify which tags to use and how to set up the link structure in HTML. I chose to use a list, it worked even though I didn't know if it was correct to do it that way.
What specific areas of your project would you like help with?I would like help with the a
tags, I would like an opinion on whether this is correct or if there is a simpler way to do it. thanks!
Community feedback
- @Carson-HaskellPosted 4 months ago
Amazing job, Josiane! That looks amazing. I have a few comments (since I am encouraged to give feedback :) )
- To better match the design, your profile picture should be a bit larger. I think it's supposed to be 58px x 58px or something like that. When doing the side-by-side, you can tell it's definitely smaller!
- On the hover state of your links, the text color is supposed to change to black. It's really hard to read the white text against the green background!
- I think your solution of using an unordered list totally works, but it would be easier and more semantic if you used a <nav> tag and then nested <a> tags for your links. For example:
<nav> <a href="/linktoyoursite.com" alt="link to ____ site">Website</a> <a href="/anotherlinktoanothersite.com" alt="same thing">Another Website</a> </nav>
It is common convention to use <a> (link) tags for anything that takes you somewhere else (i.e., to another website). It also makes styling easier, you just have to set
text-decoration: none
to get rid of the underline!- Finally, regarding accessibility, when you tab through the social links, you should use the focus pseudo-selector to style it and make it clearer which link you are currently on. For example:
.social-link:focus { background-color: // whatever color }
Marked as helpful1@josifermaodevPosted 4 months ago@Carson-Haskell Thank you very much, your explanation was very good!
0@Carson-HaskellPosted 4 months agoHappy to hear that! Keep up the amazing work :) @josifermaodev
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord