Design comparison
Solution retrospective
I am most proud that I am adapting to the environment and learning new stuffs everyday since the day I started.
What challenges did you encounter, and how did you overcome them?I had trouble with the CSS variables I placed on my code, at first it was not working and searched and searched for answers on the internet. The values were hsl colors and i thought that maybe it is not a valid value. I then review it again and again until I found out the there are no percentage included in the first value of the hsl. I typed hsl(0%, 0%, 8%) when it was supposed to be hsl(0, 0%, 8%).
What specific areas of your project would you like help with?I am having difficulties understanding the media query once again. I don't know if what I did this time is right or wrong. I also think that there maybe something wrong with my selectors img + p, img + p + p, and img + p + p + p. Are there other ways to use selectors other than this? Lastly, If there are some other improvements that can be made with my code please feel free to comment and point out what I got wrong. Many thankss! :)
Community feedback
- @danielmrz-devPosted 5 months ago
Hello there!
Congrats on completing the challenge! ā
Your solution is really impressive!
I've got a couple of ideas (about how to use HTML better) that could make it even stronger:
š First: Think about using
<main>
to wrap your main content instead of<div>
.Imagine
<div>
and<span>
in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.š Second: Consider employing
<h1>
to<h6>
tags for headings rather than using<p>
.The
<p>
tag is primarily intended for paragraphs. When it comes to headings, HTML offers us a range of heading tags: from<h1>
to<h6>
.Here's a quick guide on how to use them:
- The
<h1>
to<h6>
tags are used to define HTML headings. <h1>
is for the most important heading.<h6>
is for the least important heading.- Stick to just one
<h1>
per page ā it should be the main title for the whole page. - And don't skip heading levels ā start with
<h1>
, then use<h2>
, and so on.
It's more than just text size ā it's about structuring your content effectively.
These tweaks might not change how your page looks, but they'll make your HTML code clearer and help with SEO and accessibility.
Hope that's helpful!
Keep up the great work!
Marked as helpful0@0653JericoPosted 5 months ago@danielmrz-dev Thank you sir! I will be applying these soon.
0 - The
- @DarkstarXDDPosted 5 months ago
- You shouldn't use selectors like this. What you should do is give each element you want to select, a class name. Use that class name to style.
- Content should be wrapped in landmark elements. This page needs a
<main>
. read - You can change the
<div class="container">
to be<main class="container">
. - The name of the person is a heading. You could use a
<h1>
. - Font sizes should be in
rem
. Not inpx
. read - Would be better if you have the
max-width
also inrem
, instead ofpx
. - The
min-height
is not needed on the.container
.
Marked as helpful0@0653JericoPosted 5 months ago@DarkstarXDD Thank you sir, I will be applying these soon.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord