Design comparison
Solution retrospective
Getting the width of the li
tags to fit the socials
container
It's still a work in progress, but constructive feedback would be appreciated
Community feedback
- @AdrianoEscarabotePosted about 18 hours ago
Hi Uyoyo Whiskey, how are you doing? I really loved the outcome of your project, but I have a few suggestions that I think might be helpful:
To improve the semantics and accessibility of your code, consider using the
<ul>
(unordered list) element to group related links. The<ul>
tag is ideal for representing collections, such as a list of social media links or navigation items.Using
<ul>
not only makes your code more structured and meaningful, but it also helps assistive technologies identify the group as a related set of items, enhancing the experience for screen reader users. Additionally, this approach improves overall readability and maintainability of your HTML.Example:
<ul> <li><a href="#">GitHub</a></li> <li><a href="#">Frontend Mentor</a></li> <li><a href="#">LinkedIn</a></li> <li><a href="#">Twitter</a></li> <li><a href="#">Instagram</a></li> </ul>
In this example:
- The <ul> wraps the entire group, indicating that these links are related.
- Each item is enclosed in a <li> (list item), which provides a clear structure and logical grouping.
This method is particularly useful for navigation menus, social media links, or any set of grouped items, offering better support for both SEO and screen readers.
Pro Tip: Avoid using
<div>
elements alone for lists, as they don’t convey the same semantic meaning. Whenever possible, choose semantic tags like<ul>
or<ol>
to improve the quality of your code.The rest is excellent.
I hope you find it useful. 👍
0@Uyoyo-WPosted about 2 hours ago@AdrianoEscarabote Thank you so much for your feedback! I'll implement the changes
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord