Social Links Profile (SCSS)

Community feedback

• 

  Alex•3,130

  @Alex-Archer-IPosted 3 months ago

  Hey!

  That a first time when I see such usage of h1 tag! It's cool finding, but I think a bit redundant =)

  And a few tips =)

  • You can reduce the number of tags you use. For example, you have section tag so there is no need in container div, or, the img tag could be styled directly without wrapper.
  • This is a links, so a tag more suits here than buttons. Also this is a list, so you can use ul and li.

  <ul>
      <li><a href="#">Link here!</a></li>
      <li><a href="#">Link here!</a></li>
      <li><a href="#">Link here!</a></li>
  </ul>
  

  Overall, you did great work, and it's very cool that you are trying to paid attention to accessibility and optimization =)

  Marked as helpful

  1

  ---

  

  Liam Tanfield•260

  @TanDevvPosted 3 months ago

  @Alex-Archer-I Hi, Alex!

  You're completely right about the buttons, I will be honest I actually know you should add a tags for links, I don't know why I added buttons I think I was in autopilot during developing this and I didn't even notice! I definitely would have done the links like you suggested via a ul tag.

  The h1 tag was actually suggested to me by another long-time user of this website when you don't find a h1 appropriate anywhere so you can add it for screen-users, I'd say it may not be necessary for this project but I tend to like to add it when I can't find a place for a h1.

  I agree with the number of tags, I definitely could have been a bit cleaner with how many I added, I think it is a bad habit of mine that I like to add img tags in a container as I feel like it makes them easier to style but I think you're right that it isn't necessary.

  Thank you for the suggestions, I appreciate it :)

  1

  

  Alex•3,130

  @Alex-Archer-IPosted 3 months ago

  @TanDevv

  Well, they looks very like buttons, so it's easy to confuse them during the hard work mode 😅

  I get you point about h1, but I think that since it's purpose more like title than description, almost anything could be the h1. For example if you look to your profile page here, on the Frontend Mentor, you'll see that your name is h1. So I guess "Jessica Randall" fit here as well.

  And you're welcome! Feel free to ask, comment and stuff if need =)

  1