Design comparison
SolutionDesign
Community feedback
- @Alex-Archer-IPosted 4 months ago
Hi!
Cool work, congrats =)
A couple of uninvited suggestions.
Use more semantic tags. This is a list of links, so you should use
ul
withli
here.<ul> <li><a href="#">Link here!</a></li> ...more links here </ul>
And every page should contain
main
tag. It could be a.card
in your case.Also try to use
rem
values for font size instead ofpx
. They depends on users font settings, so it's good practice. By default1rem = 16px
Cool using of clamp, by the by, I'm just trying to find good patterns about it =)Hope that helps =)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord