Social links profile

Community feedback

• 

  P

  Steven•160

  @stevensunaPosted 3 months ago

  Semantic HTML:

  You could use a <header> element to wrap the img, h1, and h2 elements. This would group the introductory content of the profile card.

  The p tag with the bio could be placed inside an <article> or <section> to group it with related content.

  The links could be placed inside a <nav> element, as they represent a navigation menu.

  Heading Hierarchy: The h2 for "London, United Kingdom" is semantically a bit odd. It might be better to use a div or span with specific class or p tag since it's not really a heading that introduces a new section.

  Link Classes: The repeated use of class="main__a" is not very maintainable. It would be better to use more descriptive and reusable classes if you plan to style other links similarly later.

  Attribution Links: The link in the attribution could also have a more specific class for styling purposes

  Marked as helpful

  1

  ---

  

  Isaac Alvarez•250

  @isAlvarezDevPosted 3 months ago

  @stevensuna Thanks for the recommendations man. I appreciate it, I'm going to do the changes you told me :)

  0