Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social links profile page using flexbox

elliotโ€ข 30

@e-liasz

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

Just proud overall of how this turned out. It has actually been done for a week, just sitting in my files waiting for deployment.

What challenges did you encounter, and how did you overcome them?

I feel like this time around there weren't many obstacles. The code could maybe be a bit neater, but I think that will come with more practice.

What specific areas of your project would you like help with?

Any feedback is welcome as always!

Community feedback

P
Koda๐Ÿ‘นโ€ข 3,810

@kodan96

Posted

hi there! ๐Ÿ‘‹

I packed up a couple of tips for after looking at your code:

HTML:

  • for SEO and accessibility, all content within the body should be wrapped inside milestones. these milestones are the header, main and footer tags. for a project like this use at least a <main> tag.

  • for the same reason your <a> tags should be placed into a <ul> and <li> tags and not <div> tags:

<ul>
    <li><a href="">Github</a></li>
    ...
</ul>

CSS:

  • don't apply width or height to your elements, it kills responsivity, let the child elements determine these dimensions. If you really want to control your element's dimension use max-width or min-width along with the width property, but using relative units for it instead of pixels:
.card {
width: 90%;
max-width: 40rem;
}

in this case the .card element will take up 90% percent of the parent container' width, but when it reaches 40rem in width it stops expanding any further.

Hope this was helpful ๐Ÿ™

Good luck and happy coding! ๐Ÿ™Œ

Marked as helpful

1

elliotโ€ข 30

@e-liasz

Posted

@kodan96 Thank you so much for taking the time to go through the code and point these out! It is much appreciated and I will surely take my time to improve on these in the future ๐Ÿ™

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord