Social Links Profile Page

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @Divya4879

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it. Nice addition to add your own color-theme! Very good that you completed the project within your estimated time-frame.

  Things I like about your solution 🎉

  • Responsive
  • Clear descriptive CSS classes

  Things you could improve ✍️

  • Try putting your buttons in a list and changing them into links, this way you get the cursor pointer automatically.

  • Try using a heading tag for the name on the card to make it more semantically correct.

  • Good job on centering your card using position: absolute, maybe next time you can use something like Flexbox to center it?

  • Try using relative units rem and em for your font-sizes.

  • Try using CSS variables to make your values more reusable across your code.

  I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  Marked as helpful

  0

  ---

  

  Divya•50

  @Divya4879Posted 4 months ago

  @DylandeBruijn Thank you so much for your valuable feedback. It's well-thought of and really helpful.

  I'll implement the changes soon. Thanks again.

  1
• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 4 months ago

  Hey there!

  Congrats on finishing the challenge! ✅

  Your solution looks awesome!

  📌 It's a good idea to use semantic HTML elements like <ul> and <li> for lists. This makes your code more accessible, maintainable, and meaningful.

  Here's an example of how you can refactor your code:

  After Refactoring

  <ul class="list-container">
      <li><a href="#">Github</a></li>
      <li><a href="#">Frontend Mentor</a></li>
      <li><a href="#">LinkedIn</a></li>
      ...
  </ul>
  

  Using <ul> and <li> makes your content structure clearer, which is better for screen readers and search engines. Plus, it follows best practices for HTML.

  Hope this helps!

  Keep up the great work!

  0