Skip to content
Submitted 6 months ago

Social Links profile page

Olga•190
@cvtqx
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I love the HTML structure of my page, which seems clear and neat, and I tried to follow BEM convention for class naming.

What challenges did you encounter, and how did you overcome them?

I started learning Sass while working on this project. But I couldn't figure out how to deploy webpage with sass in it so I had to remove it from my project and used plain css.

What specific areas of your project would you like help with?

How to deploy a webpage styled with Sass.

Community feedback

  • caseem•330
    @kass8mal8Posted 6 months ago

    Your solution is good and includes semantic html.Make the following adjustments and it will be better.

    • The links are embedded in div tags which creates a lot of tags, they should be embedded in li tags for accessibility
    • The bit about sass, use a sass compiler which generates CSS code from your sass then import your CSS as usual.
    Marked as helpful
    0
    Olga•190
    @cvtqxPosted 6 months ago

    Hi @kass8mal8 ,

    thank you for reviewing my work. It's good to know the proper way to structure a list of links. I have updated the code to include ul and li. I was using gulp for compiling sass (following a tutorial) but still had trouble figuring out how to publish the page after all.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord