Design comparison
Solution retrospective
Getting familiar and able to apply flexbox in a project. Projects that I have worked on uses the old ways of structuring a div. In my upcoming projects will incorporate flexbox instead as it is easy to use.
What challenges did you encounter, and how did you overcome them?Applying the correct margins and sizes. Also had slight roadblocks in centering items in the body. It would be easier if I were to have a figma access for this project. But was able to solve my problems using the dev tools in chrome.
What specific areas of your project would you like help with?I would like to have suggestions on how do I enhance my html and css structure in the project. I have been a backend developer mostly in my career and I want to refresh my knowledge with my frontend development.
Community feedback
- @jonathancklee1Posted 7 months ago
Hi Mariele, First of all, great work on your project!
To give feedback for your question, I would personally not use the header tag in this situation because, in the context of a real-life website, this is a reusable card that is not used to define the headings or navigation of a page. However, in this context, it is OKAY as your card is the only element on the page.
Also in a header, you will need to have child elements such as heading tags within it so I will add a h1 tag to the name. And I would put any user-defining elements inside it like the image, name and job title.
<header class="title"> <img src="/assets/images/avatar-jessica.jpeg" class="profile-pic"> <h1> Jessica Randall </h1> <span class="description"> London, United Kingdom </span> </header>I hope my feedback will be useful. Again awesome work!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord