Social Links Profile

Community feedback

• 

  P

  chelsea-here•160

  @chelsea-herePosted 5 months ago

  Hi there, it looks like you are missing focus states. You can add it in a very similar manner to how you added hover states in tailwind.

  < a className="focus:bg-green focus:text-gray">text here</a>
  

  Regarding your html the only thing I'm not clear on is why you would add an div below your body and above your main element. Otherwise, looks good to me. Cheers!

  1

  ---

  

  P

  Hadeed Ahmad•140

  @hadeedjiPosted 5 months ago

  @chelsea-here Thanks for feedback. I always forget the focus states, wish there was a way to have the same hover and focus styles, because in most cases you want the same ones, is that correct?

  About the div, I used to always surround everything by a div and use that for centering, bg etc, because I had this idea that I shouldn't add classes to the body element, but in a later challenge I did add classes to body. Would you say that's preferable?

  0