Social links profile

Community feedback

• 

  Hassan Moataz•1,860

  @hassanmoaaPosted 9 months ago

  Hello @Benji!

  Great Job solving the challenge mate congrats 🎉

  Some suggestions for improvements.

  For the font-size it's is recommended to use rems and ems.

  font-size: 13px;

  i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:

  Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.

  Which properties are affected?

  All of these properties must never ever be declared in pixels:

  • font-size
  • line-height
  • letter-spacing

  If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!

  You should use ems, and rems for font-sizes would be better

  This article may help:

  https://fedmentor.dev/posts/font-size-px/

  ➖➖➖➖➖➖➖➖

  Other than that you're good, keep up the good work!

  Marked as helpful

  0

  ---

  

  Benji•270

  @Benji963Posted 9 months ago

  @hassanmoaa OK, thank you for the advice I've changed it to rem for the font size from GitHub. From now on I won't use pixels for the font size, line height, or letter spacing.

  0