Design comparison
Solution retrospective
I used to have issues with centering the card onto the center of the page, I was told about min/max height from a reviewer had given a solution to it in a previous challenge, Thank you! and that was fixed.
What specific areas of your project would you like help with?On 'role' or ARIA as landmarks... Is it better that I make it a good coding practice early on? and feel free to give any other tips and tricks for later projects!
Community feedback
- @danielmrz-devPosted 4 months ago
Hey!
Congrats on finishing the challenge! ā
Your solution looks awesome!
š It's a good idea to use semantic HTML elements like
<ul>
and<li>
for lists. This makes your code more accessible, maintainable, and meaningful.Here's an example of how you can refactor your code:
After Refactoring
<ul class="list-container"> <li><a href="#">Github</a></li> <li><a href="#">Frontend Mentor</a></li> <li><a href="#">LinkedIn</a></li> ... </ul>
Using
<ul>
and<li>
makes your content structure clearer, which is better for screen readers and search engines. Plus, it follows best practices for HTML.Hope this helps!
Keep up the great work!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord