Social Links Profile Main

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 6 months ago

  Hello there!

  Congrats on completing the challenge! ✅

  Your solution looks great!

  📌 It's recommended to use semantic HTML elements like <ul> and <li> for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.

  Here's and example on how you can refactor your code:

  After Refactoring

  <ul class="list-container">
      <li><a href="#">Github</a></li>
      <li><a href="#">Frontend Mentor</a></li>
      <li><a href="#">LinkedIn</a></li>
      ...
  </ul>
  

  By using <ul> and <li>, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.

  I hope you find this helpful!

  Keep up the excellent work!

  Marked as helpful

  0
• 

  Rachel Tschanz•210

  @rtdevcraftPosted 6 months ago

  Hi there!

  This is a close solution!

  1. Try out using more semantic HTML instead of just using divs
  2. Looks like the container could use a border-radius
  3. Get rid of the border on the buttons to more closely match the design
  4. Move the attribution below the container
  5. Delete commented out CSS code if you wont be using it

  Marked as helpful

  0