@gautam32b7
Posted
Hi there!
Great job! I reviewed your code and found some mistakes. A few tips:
:root {
--green: hsl(75, 94%, 57%);
--White: hsl(0, 0%, 100%);
--Grey: hsl(0, 0%, 20%);
--Dark-Grey: hsl(0, 0%, 12%);
--Black: hsla(0, 0%, 8%);
}
* {
margin: 0;
padding: 0;
box-sizing: border-box;
letter-spacing: 0.06rem;
}
Always put the reset at the top
* {
margin: 0;
padding: 0;
box-sizing: border-box;
letter-spacing: 0.06rem;
}
:root {
--green: hsl(75, 94%, 57%);
--White: hsl(0, 0%, 100%);
--Grey: hsl(0, 0%, 20%);
--Dark-Grey: hsl(0, 0%, 12%);
--Black: hsla(0, 0%, 8%);
}
Proper way to structure the HTML
links
<div>GitHub</div>
<div> Frontend Mentor
</div>
<div>LinkedIn</div>
<div>Twitter</div>
<div> Instagram
</div>
<ul>
<li><a href="#">Frontend Mentor</a></li>
<li><a href="#">LinkedIn</a></li>
<li><a href="#">Twitter</a></li>
<li><a href="#">Instagram</a></li>
</ul>