Skip to content
Submitted 4 months ago

social-links-profile-main

MaxBidder76•40
@MaxBidder76
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am proud of the fact that the design is well the page is responsive on mobile and any screen sizes.

What challenges did you encounter, and how did you overcome them?

My major challenge was making my text color change when hovering. I made more research on that to solve it.

Community feedback

  • Joe-FE•50
    @Joe-FEPosted 4 months ago

    Dear MaxBidder,

    Firstly, congratulations on completing your third project on Frontend Mentor! It's great to see your progress and dedication to improving your front-end skills.

    Project Summary

    Your social links profile page is well-structured and demonstrates a good understanding of HTML5 and CSS3. The design is simple and clean, which is excellent for user experience.

    Tips that may help you:👇

    HTML:

    1. Structure: Your HTML structure is clear and semantic, which enhances accessibility and SEO.
    2. Accessibility: Consider adding alt attributes to all images for improved accessibility.
    3. Consistency: Ensure consistent use of tags and their classes.

    CSS:

    1. Flexbox/Grid: Good use of Flexbox for layout. Consider using CSS Grid for more complex layouts.
    2. Responsive Design: The page is responsive. Testing on various devices and screen sizes might help catch any issues.
    3. Hover Effects: The hover effects on links work well. Ensure the color contrast is sufficient for accessibility.

    Detailed Suggestions

    1. HTML Enhancements:

      • Add lang attribute to the <html> tag to define the document's language.
      • Use more semantic tags (e.g., <header>, <footer>) if applicable.

    2. CSS Improvements:

      • Use CSS variables for colors and fonts to maintain consistency and ease future updates.
      • Add more comments to explain different CSS sections, which can help with maintenance.

    Conclusion

    The project is a good start and demonstrates a clear understanding of HTML and CSS fundamentals. By addressing the suggestions above, your code will become more maintainable, accessible, and professional. Keep up the great work and continue to refine your skills!

    Best regards, [Youssef Salem]

    0
  • Dylan de Bruijn•3,230
    @DylandeBruijnPosted 4 months ago

    @MaxBidder76

    Hiya! 👋

    Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

    Things you could improve ✍️

    • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

    • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

    • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

    • I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

    • Try using semantic HTML elements like main, section and article.

    • Try using using relative CSS units like rem and em they make your layout more adaptable.

    • Try putting your links in a list (ul) to make your code more semantic.

    I hope you find my feedback helpful! 🌟

    Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

    Happy coding! 😎

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord