Boris• 2,870
@mkboris
Posted
Nice work youssefcharfeddine, here are a few things to review
- All content should be wrapped within landmarks. Wrap a
main
tag around .container - The social links are anchor
a
tags. It's not good practice to wrap every element indiv
because divs aren't semantic. Also using an unordered listul
to group the social media links is a better approach for both semantics and accessibility. Like so
<ul>
<li>
<a href="#">Github</a>
</li>
</ul>
- Avoid setting fixed heights and widths on elements, as this can create problems with responsiveness and content fit. Instead, let the content and
padding
determine the element’s size. If necessary, usemax-width
ormin-height
, and prefer relative units likerem
for better adaptability. Remove theheight
from your .container and change thewidth
tomax-width
and it should be defined inrem
not px - It's best practice linking Google fonts directly in the HTML
head
section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times. - Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
- Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
Hope this helps
Marked as helpful
0