social-links-profile-main

Community feedback

• 

  Boris•2,850

  @mkborisPosted 4 months ago

  Nice work youssefcharfeddine, here are a few things to review

  • All content should be wrapped within landmarks. Wrap a main tag around .container
  • The social links are anchor a tags. It's not good practice to wrap every element in div because divs aren't semantic. Also using an unordered list ul to group the social media links is a better approach for both semantics and accessibility. Like so

  <ul>
    <li>
      <a href="#">Github</a>
    </li>
  </ul>
  

  • Avoid setting fixed heights and widths on elements, as this can create problems with responsiveness and content fit. Instead, let the content and padding determine the element’s size. If necessary, use max-width or min-height, and prefer relative units like rem for better adaptability. Remove the height from your .container and change the width to max-width and it should be defined in rem not px
  • It's best practice linking Google fonts directly in the HTML head section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.

  Hope this helps

  Marked as helpful

  0

  ---

  

  youssefcharfeddine•110

  @youssefcharfeddinePosted 4 months ago

  Thanks for the helpful advice @mkboris

  1