Design comparison
Solution retrospective
I'd appreciate any feedback but I'd like any advice on:
- Use of media queries
- HTML semantics
- Spacing
Thank you.
Community feedback
- @Ezekiel225Posted 9 months ago
Hello there π @davidptclark.
Good job on completing the challenge !
Your project looks really good!
I have a suggestion about your code that might interest you.
There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.
I hope this suggestion is useful for future projects.
Keep up the excellent work and continue to challenge yourself with new projects. Your progress is impressive, and each project is a step forward in your front-end development journey! ππ.
Other than that, great job!
Happy coding.
Marked as helpful0 - @danielmrz-devPosted 9 months ago
Hello @davidptclark!
Your solution looks excelent!
I have just one suggestion:
π Consider this tweak for your HTML code:
To improve semantic clarity, opt for
<h1>
over<h2>
for your main title.It's more than just text size β it's about structuring your content effectively:
<h1>
to<h6>
are used to define HTML headings, with<h1>
being the most significant.- Stick to one
<h1>
per page for the main title, and maintain the titles hierarchy with<h1>
,<h2>
<h3>
, and so on.
While these adjustments might not alter the visual appearance much, they significantly enhance semantic clarity, SEO optimization, and accessibility.
Hope this suggestion proves helpful! Keep up the great work!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord